MPP-4165 Megabundle Pricing Grid #5603
Conversation
| plan-grid-megabundle-subtitle = 3 privacy tools, 1 price | ||
| plan-grid-megabundle-vpn-title = { -brand-name-mozilla-vpn} | ||
| plan-grid-megabundle-vpn-description = Online activity protection | ||
| -brand-name-monitor-plus = Monitor Plus |
There was a problem hiding this comment.
comment (non-blocking): this is fine, but it got me looking around at the brand message IDs. It looks like we've got -brand-name-mozilla-monitor in the l10n repo now:
https://github.com/mozilla-l10n/fx-private-relay-l10n/blob/9cea8ff34e99356f5d5586bfd86b667af89d1ba9/en/brands.ftl#L23
So we could probably remove -brand-name-mozilla-monitor from this file while we're in here?
There was a problem hiding this comment.
yeah i can do that when i make the l10n pr
| const total = plan.price * 12; | ||
| const formatter = new Intl.NumberFormat(getLocale(l10n), { | ||
| style: "currency", | ||
| currency: plan.currency, | ||
| }); | ||
| return formatter.format(total); |
There was a problem hiding this comment.
suggestion (non-blocking): these lines are repeated x3. Could move to a function?
There was a problem hiding this comment.
yeah i was thinking that also for this
| {isMegabundleAvailableInCountry(runtimeData.data) ? ( | ||
| <PlanGrid runtimeData={runtimeData.data} /> | ||
| ) : ( | ||
| <PlanMatrix runtimeData={runtimeData.data} /> | ||
| )} |
There was a problem hiding this comment.
question (non-blocking): is this the right behavior? Do we want to only show the new PlanGrid component if the megabundle is available? Or do we want to always show the PlanGrid and never show the PlanMatrix component?
There was a problem hiding this comment.
my understanding is plan grid (new component) should show to those who have megabundle - ie usa - and then plan matrix with show otherwise
There was a problem hiding this comment.
The ticket acceptance criteria isn't clear about it. Check with product in the Slack channel?
| {isMegabundleAvailableInCountry(runtimeData.data) ? ( | ||
| <PlanGrid runtimeData={runtimeData.data} /> | ||
| ) : ( | ||
| <PlanMatrix runtimeData={runtimeData.data} /> | ||
| )} |
There was a problem hiding this comment.
same-as-above-question (non-blocking): is this the right behavior? Do we want to only show the new PlanGrid component if the megabundle is available? Or do we want to always show the PlanGrid and never show the PlanMatrix component?
MPP-4165
Screenshot (if applicable)
Mobile
Tablet
Desktop
How to test
Checklist (Definition of Done)
/frontend/src/styles/colors.scss).